Neboat/cfg invariants #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifferent parts of MemorySSA all use the same TaskInfo.
…ndle cases where an alloca is used only in one spindle, but that spindle does not match the spindle where the alloca is defined.
…ities and passes to treat exit blocks inside of tasks within a loop as part of the loop.
This commit uses the custom ValueMaterializer to properly materialize a specified input syncregion, i.e., to ensure that any associated debug info is properly updated. In the future, this change may be extended to support additional Target-specific customization of the Tapir outlining process.
…sforming a Tapir function with taskframes for CSI or CilkSanitizer instrumentation. In particular, ensure that inserted cleanup blocks properly respect taksframe instrinsics; preserve the structural property that detaches unwind to the same destination as associated detached.rethrows; and exclude inserting instrumentation in placeholder basic blocks.
…te modifies the CFG.
…ias if an identified object underlying one access cannot escape before the other access.
…nto the spawned body of a Tapir loop in the continuation of a spawn in the caller is properly enclosed in a taskframe.
… and associated detached.rethrow destination are the same.
…ck that syncregions are not used in subtasks. Update test cases to satisfy Tapir task-structure verification.
…width to the outlined function it creates.
…noalias call or identified object assuming the Value is in the same spindle.
…te pointers with casts.
…h atomic instrumentation. Fixes OpenCilk#30
This was referenced Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust a few passes to maintain a simpler CFG structure for spawned tasks, namely, that the unwind destination of a detach matches the destination of a detached-rethrow. Augment the Verifier to check that Tapir tasks maintain the correct structure. Bug fixes.