Feature request: an API to register externally defined tapir target #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2021
This was referenced Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature request/question on the API for using externally defined tapir target. IIUC, opencilk does not have an API for this. Can we have, for example, a method
where
targetis a function that takes a module and return a target? This is how I actually use it.I'm not suggesting this particular API and this PR is just to concretely illustrate what functionality I'd like to access. Also, this implementation is terrible and have to be written in such a way that you don't need to use a global variable (This patch is optimized for minimal diff ATM). If this API is OK to add, I can try moving the state into
TargetLibraryInfoImpl.