Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export icons according to XDG icon spec on unix #520

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

matterhorn103
Copy link
Contributor

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@matterhorn103
Copy link
Contributor Author

matterhorn103 commented Nov 4, 2024

This means we will then be following the XDG icon spec, as practised on all modern Linux distros and as required by flatpak-builder-lint.

@ghutchis
Copy link
Member

ghutchis commented Nov 5, 2024

Can you remove the clang-format commits from this? I'd rather do that separately. It looks like you're using a different version of clang-format.

@matterhorn103
Copy link
Contributor Author

Done.

I had applied the diff that the automatic clang-format check produced, so which version I have shouldn't matter - it should have been in agreement with whichever version of it the GitHub Action uses. But it's no matter, I hadn't changed any C++ files anyway.

@ghutchis ghutchis merged commit 37724ee into OpenChemistry:master Nov 6, 2024
38 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants