feature/OP-145/json-config #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP; this is not a finished product.
This pull request includes:
Addition of JSON-config logic (instead of solely .env config);
Addition of the Conduction and Common Ground JSON-config files (initial ones, still need refining and testing);
Removal of redundant tokens and code (old .env tokens and callback files);
To-do's:
Add Rotterdam (and other requested organizations) JSON-config files;Make Common Ground the default theme, not Conduction;Add Common Ground header items (or make a default; currently its grabbing the Conduction ones);Thoroughly test everything, nothing has been tested yet;Maybe to-do:
Move the ThemeSwitcherTopBar to conduction/components (we're currently also using this in woo-website-template, so it's being duplicated).