feature/OP-108/pagination-limit #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lencodes
suggested changes
Oct 31, 2023
There was a problem hiding this comment.
Very nice! Left some inline comments, also have a few other global comments.
- Display is not set automatically (unsure if that changed in this pull request, but it's there), see screenshot; because of this the results don't actually show:
- When setting a higher amount of results, there's a big enough scroll to completely remove the filters view in the components template, see screenshot:
I think we should make the filters sticky, keeping them in view when scrolling.
pwa/src/components/paginationLimitSelect/PaginationLimitSelect.module.css
Outdated
Show resolved
Hide resolved
…/pagination-limit
Conflicts: pwa/src/apiService/resources/applications.ts pwa/src/apiService/resources/organization.ts pwa/src/apiService/resources/search.ts pwa/src/context/filters.ts pwa/src/context/global.ts pwa/src/hooks/applications.ts pwa/src/hooks/organization.ts pwa/src/hooks/search.ts pwa/src/templates/applicationsTemplate/ApplicationsTemplate.tsx pwa/src/templates/components/ComponentsTemplate.tsx pwa/src/templates/organizationsTemplate/OrganizationsTemplate.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.