Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before actually implementing the query params, I thought it'd be better to first implement our new filters way of working (open catalogi was still using older methods).Also before implementing the query params, I'd like to merge this to minimise the code changes per pull request.Forgot to merge this timely, but the additional changes were smaller than expected, so should be okay to keep in one pull request 🤞🏼
This pull request includes:
filtersToUrlQueryParams
service, which rewrites filters to URL Query params (with URIEncoding, so that we can keep spaces);getParsedParamsFromSearch
service, which creates a JSON object from the query params (incl. decoding of numbers, arrays, booleans and the encoded strings);Known issue / to-do:
ActiveFiltersTemplate
doesn't work, unsure why at this moment