feature/DIMOC-208/fileupload-fe #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…208/fileupload-fe
…208/fileupload-fe
…/DIMOC-208/fileupload-fe
RalkeyOfficial
approved these changes
Aug 7, 2024
…ConductionNL/OpenCatalogApp into feature/DIMOC-208/fileupload-fe
…208/fileupload-fe
…208/fileupload-fe
rjzondervan
approved these changes
Aug 7, 2024
Comment on lines
+126
to
+151
| public function uploadFile(mixed $content, ?string $filePath = '', ?bool $update = false): bool | ||
| { | ||
| // Get the admin username & password for auth & get the current username | ||
| $userInfo = $this->getUserInfo(); | ||
|
|
||
| // API endpoint to upload the file | ||
| $url = $this->getCurrentDomain() . '/remote.php/dav/files/' | ||
| . $userInfo['currentUsername'] . '/' . ltrim(string: $filePath, characters: '/'); | ||
|
|
||
| try { | ||
| $response = $this->client->request('PUT', $url, [ | ||
| 'auth' => [$userInfo['username'], $userInfo['password']], | ||
| 'body' => $content | ||
| ]); | ||
|
|
||
| if ($response->getStatusCode() === 201 || ($update === true && $response->getStatusCode() === 204)) { | ||
| return true; | ||
| } | ||
| } catch (\Exception $e) { | ||
| $str = $update === true ? 'update' : 'upload'; | ||
| $this->logger->error("File $str failed: " . $e->getMessage()); | ||
| throw $e; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
Waarom buitenom via de API als er een interne route voor bestaat?
Comment on lines
+161
to
+184
| public function deleteFile(string $filePath): bool | ||
| { | ||
| // Get the admin username & password for auth & get the current username | ||
| $userInfo = $this->getUserInfo(); | ||
|
|
||
| // API endpoint to upload the file | ||
| $url = $this->getCurrentDomain() . '/remote.php/dav/files/' | ||
| . $userInfo['currentUsername'] . '/' . ltrim(string: $filePath, characters: '/'); | ||
|
|
||
| try { | ||
| $response = $this->client->request('DELETE', $url, [ | ||
| 'auth' => [$userInfo['username'], $userInfo['password']], | ||
| ]); | ||
|
|
||
| if ($response->getStatusCode() === 204) { | ||
| return true; | ||
| } | ||
| } catch (\Exception $e) { | ||
| $this->logger->error('File deletion failed: ' . $e->getMessage()); | ||
| throw $e; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
Idem, waarom buitenom als er een interne route voor is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.