Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix download files + some css issues (#9099) #9100

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

lndrtrbn
Copy link
Member

Proposed changes

  • fix some css issues
  • fix download pdf in content tab

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Nov 20, 2024
@lndrtrbn lndrtrbn self-assigned this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.69%. Comparing base (a0a5121) to head (a9b3925).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9100   +/-   ##
=======================================
  Coverage   64.69%   64.69%           
=======================================
  Files         620      620           
  Lines       59210    59210           
  Branches     6523     6520    -3     
=======================================
  Hits        38303    38303           
  Misses      20907    20907           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@delemaf delemaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Copy link
Member

@SouadHadjiat SouadHadjiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally ✅

@lndrtrbn lndrtrbn merged commit 497ca07 into master Nov 21, 2024
6 checks passed
@lndrtrbn lndrtrbn deleted the issue/9099 branch November 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants