Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] When deleting a connector in ingestion => connectors, interface is redirected to the connector and then to the list (#7828) #9024

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Remove the ListItemButton for a regular ListItem

Related issues

…rface is redirected to the connector and then to the list (#7828)
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Nov 15, 2024
@SarahBocognano SarahBocognano self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.26%. Comparing base (190083d) to head (0afe29c).
Report is 104 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9024      +/-   ##
==========================================
- Coverage   66.26%   66.26%   -0.01%     
==========================================
  Files         597      597              
  Lines       61161    61161              
  Branches     6302     6302              
==========================================
- Hits        40529    40528       -1     
- Misses      20632    20633       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok 👌

@SarahBocognano SarahBocognano merged commit 7b60bf1 into master Nov 21, 2024
6 checks passed
@SarahBocognano SarahBocognano deleted the issue/7828 branch November 21, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants