Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Get all objects pagination can stop for invalid global count (#8579) #8592

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

richard-julien
Copy link
Member

See #8579

@richard-julien richard-julien linked an issue Oct 3, 2024 that may be closed by this pull request
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 3, 2024
@richard-julien richard-julien changed the title [backend] Get all objects pagination can stop for invalid global count (#8579) [Backend] Get all objects pagination can stop for invalid global count (#8579) Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.26%. Comparing base (c1def1b) to head (78f6784).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8592      +/-   ##
==========================================
+ Coverage   66.23%   66.26%   +0.03%     
==========================================
  Files         597      597              
  Lines       60433    60440       +7     
  Branches     6202     6212      +10     
==========================================
+ Hits        40025    40049      +24     
+ Misses      20408    20391      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyCloarec
Copy link
Contributor

JeremyCloarec commented Oct 4, 2024

Tested OK and code is OK for me.
But did we find out why the report linked in the issue had the problem ? What caused the listEntitiesThroughRelationsPaginated to return only 499 entities, shouldn't we have access to all the object refs with our access rights? Is there an inconsistency in the database between the denormalized object relations on the report and the existing object relations?

@richard-julien
Copy link
Member Author

The reason is due to the fact that the rel_ are not directional in the current model.
This direction is post filtered in the query and so influence the number of result.

@richard-julien richard-julien merged commit 9973307 into master Oct 7, 2024
8 checks passed
@richard-julien richard-julien deleted the issue/8579 branch October 7, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knowledge graph is not displaying all entities
2 participants