Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] remove valid_until column in indicators list (#8520) #8521

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Sep 27, 2024

Proposed changes

we chose to remove the column valid_until from the indocator list view as it's already too crowded.

Note that I added valid_until field specs to DataTableUtils (same format as indicator creation date, date+time) if we change our mind.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 27, 2024
@labo-flg labo-flg marked this pull request as draft September 27, 2024 09:43
@labo-flg labo-flg changed the title [frontend] fix missing field valid_until in indicators list (#8520) [frontend] remove valid_until column in indicators list (#8520) Sep 27, 2024
@labo-flg labo-flg marked this pull request as ready for review September 27, 2024 17:12
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.22%. Comparing base (f31ec39) to head (397c752).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8521      +/-   ##
==========================================
+ Coverage   66.20%   66.22%   +0.01%     
==========================================
  Files         597      597              
  Lines       60422    60425       +3     
  Branches     6203     6211       +8     
==========================================
+ Hits        40005    40018      +13     
+ Misses      20417    20407      -10     
Flag Coverage Δ
66.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg merged commit 961fcf1 into master Oct 1, 2024
6 checks passed
@labo-flg labo-flg deleted the issue/8520-indicators-valid-until branch October 1, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicator valid_until field is not displayed in list view
2 participants