Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend + backend] added vulnerabilitties tab and 'has' relationship #8458

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

stefan1anuby
Copy link
Contributor

@stefan1anuby stefan1anuby commented Sep 23, 2024

Proposed changes

Added 'has' relationship between system and vulnerability:

image

Added 'Vulnerabilities' tab in the Knowledge sections of the Systems:

image

Related issues

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.05%. Comparing base (ea43d66) to head (f2bfcff).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8458   +/-   ##
=======================================
  Coverage   66.04%   66.05%           
=======================================
  Files         597      597           
  Lines       60868    60871    +3     
  Branches     6202     6202           
=======================================
+ Hits        40202    40208    +6     
+ Misses      20666    20663    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano added the community use to identify PR from community label Sep 24, 2024
@SarahBocognano SarahBocognano self-requested a review October 1, 2024 12:52
@SarahBocognano SarahBocognano self-assigned this Oct 1, 2024
@SarahBocognano
Copy link
Member

SarahBocognano commented Oct 2, 2024

Just checked your PR. The relationship creation is working well via UI and API, but there is a little miss somewhere.
We want to be able to add the relationship in related entities too.
Capture d'écran 2024-10-02 102942

In SystemKnowledge.jsx, add the "has" relationshipTypes in the "related" route and it will work perfectly ! :)

@stefan1anuby
Copy link
Contributor Author

Would it be even better if I would create a separate route in SystemKnowledge for vulnerabilities? That also means solving #8498.

@stefan1anuby stefan1anuby changed the title [backend] added 'has' relationship between system and vulnerability [frontend + backend] added vulnerabilitties tab and 'has' relationship Oct 6, 2024
@SarahBocognano SarahBocognano merged commit 3497f88 into OpenCTI-Platform:master Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants