Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix orga sharing tests (#4538) #8404

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Sep 18, 2024

Proposed changes

  • Use adminQuery() instead of queryAsAdminWithSuccess as it uses queryAsAdmin wich doesn't take cache into account

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 18, 2024
@marieflorescontact marieflorescontact marked this pull request as ready for review September 18, 2024 14:33
@marieflorescontact marieflorescontact self-assigned this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (0b50bb2) to head (b9f2423).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8404      +/-   ##
==========================================
- Coverage   66.18%   66.14%   -0.04%     
==========================================
  Files         597      597              
  Lines       60375    60375              
  Branches     6209     6194      -15     
==========================================
- Hits        39959    39937      -22     
- Misses      20416    20438      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact merged commit 080858e into master Sep 18, 2024
6 checks passed
@marieflorescontact marieflorescontact deleted the issue/fix_flaky_tests branch September 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants