Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Add a profile to run opensearch locally #8397

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Sep 18, 2024

Proposed changes

  • add a docker compose profile to run opensearch as searchengine instead of elastic for local development.

Related issues

  • no issue

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 18, 2024
@aHenryJard aHenryJard marked this pull request as ready for review September 18, 2024 16:11
@aHenryJard aHenryJard changed the title Add a profile to run opensearch locally [dev] Add a profile to run opensearch locally Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (b7e8a1a) to head (f7176dc).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8397      +/-   ##
==========================================
+ Coverage   66.13%   66.14%   +0.01%     
==========================================
  Files         597      597              
  Lines       60375    60375              
  Branches     6189     6195       +6     
==========================================
+ Hits        39930    39937       +7     
+ Misses      20445    20438       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@aHenryJard aHenryJard merged commit c90a99c into master Sep 27, 2024
6 checks passed
@aHenryJard aHenryJard deleted the oob/opensearch-docker-dev branch September 27, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants