Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Change kill_chain_phase.order attribute upsert value (#8182) #8181

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

lndrtrbn
Copy link
Member

@lndrtrbn lndrtrbn commented Aug 28, 2024

Proposed changes

  • Set upsert false to attribute order of kill chain phase

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Aug 28, 2024
@lndrtrbn lndrtrbn self-assigned this Aug 28, 2024
@lndrtrbn lndrtrbn changed the title [backend] Change kill_chain_phase.order attribute upsert value [backend] Change kill_chain_phase.order attribute upsert value (#8182) Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.06%. Comparing base (a44ccda) to head (2b6857d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8181      +/-   ##
==========================================
+ Coverage   66.05%   66.06%   +0.01%     
==========================================
  Files         597      597              
  Lines       59732    59732              
  Branches     6079     6081       +2     
==========================================
+ Hits        39455    39462       +7     
+ Misses      20277    20270       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg merged commit 285d10b into master Aug 28, 2024
5 checks passed
@labo-flg labo-flg deleted the oob/kcp-upsert branch August 28, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of kill chain phases are lost after dataset is updated
3 participants