Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Group members are inconsistent and can lead to mistakes on managing RBAC (#8050) #8098

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Change default pagination of group's member query from 20 (by default) to 500

Related issues

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Aug 19, 2024
@SarahBocognano SarahBocognano self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.23%. Comparing base (a27b344) to head (849268c).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8098   +/-   ##
=======================================
  Coverage   66.22%   66.23%           
=======================================
  Files         597      597           
  Lines       60433    60433           
  Branches     6202     6205    +3     
=======================================
+ Hits        40022    40025    +3     
+ Misses      20411    20408    -3     
Flag Coverage Δ
66.22% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -39,7 +39,7 @@ const GroupEditionContainerFragment = graphql`
rolesOrderMode: { type: "OrderingMode", defaultValue: asc }
) {
id
members {
members(first: 500) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be handled by DataTable, do not merge yet :)

@Kedae Kedae added the do not merge Do not merge this PR until this tag will be removed label Aug 19, 2024
@SouadHadjiat
Copy link
Member

What is the status of this PR @Kedae now that data tables have been merged?

@labo-flg
Copy link
Member

Not fixed by latest changes to DataTables.
GroupEditionContainer now uses a DataTableWithoutFragment, which does not include pagination. passed 20 members selected, the list in the drawer does not work right.

@labo-flg labo-flg removed the do not merge Do not merge this PR until this tag will be removed label Sep 26, 2024
@labo-flg
Copy link
Member

labo-flg commented Sep 26, 2024

@SarahBocognano please check against latest master if the issue is still here.
You can apply your quick fix if it solves the problem.

@labo-flg After checking with lastest master branch, the problem still occurs. The fix made by this PR is fixing it though

@SarahBocognano
Copy link
Member Author

Update: This PR is still valid because de data tables didn't resolved the pagination problem

@SarahBocognano SarahBocognano merged commit 0682000 into master Oct 2, 2024
6 checks passed
@SarahBocognano SarahBocognano deleted the issue/8050 branch October 2, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants