-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Group members are inconsistent and can lead to mistakes on managing RBAC (#8050) #8098
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8098 +/- ##
=======================================
Coverage 66.22% 66.23%
=======================================
Files 597 597
Lines 60433 60433
Branches 6202 6205 +3
=======================================
+ Hits 40022 40025 +3
+ Misses 20411 20408 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -39,7 +39,7 @@ const GroupEditionContainerFragment = graphql` | |||
rolesOrderMode: { type: "OrderingMode", defaultValue: asc } | |||
) { | |||
id | |||
members { | |||
members(first: 500) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be handled by DataTable, do not merge yet :)
What is the status of this PR @Kedae now that data tables have been merged? |
Not fixed by latest changes to DataTables. |
f8359b7
to
558e6c1
Compare
@SarahBocognano please check against latest master if the issue is still here. @labo-flg After checking with lastest master branch, the problem still occurs. The fix made by this PR is fixing it though |
c1cddb1
to
849268c
Compare
Update: This PR is still valid because de data tables didn't resolved the pagination problem |
Proposed changes
Related issues