Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api/frontend] Add an About tab with the version information in the Settings (#236) #259

Merged
merged 3 commits into from
Oct 15, 2019
Merged

[api/frontend] Add an About tab with the version information in the Settings (#236) #259

merged 3 commits into from
Oct 15, 2019

Conversation

maertv
Copy link
Contributor

@maertv maertv commented Oct 14, 2019

No description provided.

@maertv
Copy link
Contributor Author

maertv commented Oct 14, 2019

I mentioned in the issue (link) that (as far as I know) the Grakn server does not expose its version. Therefore the current implementation has hard-coded Grakn version.

The Grakn Node.js client has an open (link) issue that includes the discussion about exposing the server version.

@richard-julien richard-julien merged commit 17761e2 into master Oct 15, 2019
@richard-julien richard-julien deleted the issue/236 branch October 15, 2019 11:57
@richard-julien
Copy link
Member

Thanks again. I rework some part to have an API closer to the expected UI.

@maertv
Copy link
Contributor Author

maertv commented Oct 15, 2019

Yes, it is much better with your modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelHassine SamuelHassine Awaiting requested review from SamuelHassine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maertv @richard-julien