Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate function askEnrich in the API #390

Closed
SamuelHassine opened this issue Dec 20, 2019 · 0 comments
Closed

Duplicate function askEnrich in the API #390

SamuelHassine opened this issue Dec 20, 2019 · 0 comments
Assignees
@richard-julien
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR) technical improvement Technical refactor or improvement is needed
Milestone
Release 2.1.3

Comments

@SamuelHassine
Copy link
Member

SamuelHassine commented Dec 20, 2019 •
edited
Loading

Problem to Solve

The function askEnrich is in the Indicator.js and the StixObservable.js.

Current Workaround

None.

Proposed Solution

Use only one function in an otherfile but avoid dependency cycle.

Additional Information

None.
@SamuelHassine SamuelHassine added feature use for describing a new feature to develop technical improvement Technical refactor or improvement is needed labels Dec 20, 2019
@SamuelHassine SamuelHassine added this to the Release 2.1.3 milestone Dec 20, 2019
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Dec 26, 2019
SamuelHassine pushed a commit that referenced this issue Dec 30, 2019
@richard-julien
[api] Introduce enrichment.js to solve code duplication (#390)
4becbeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-julien richard-julien

Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR) technical improvement Technical refactor or improvement is needed
Projects
None yet
Milestone
Release 2.1.3
Development

No branches or pull requests
2 participants
@richard-julien @SamuelHassine