Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sentinel] Split former Sentinel connector into two new connectors (external import and stream) #2749

Merged
merged 25 commits into from
Oct 11, 2024
Merged

[Sentinel] Split former Sentinel connector into two new connectors (external import and stream) #2749

merged 25 commits into from
Oct 11, 2024

Conversation

Powlinett
Copy link
Member

@Powlinett Powlinett commented Oct 2, 2024 •
edited
Loading

Proposed changes

  • Create sentinel-incidents (external import connector)
    • use external import template
    • remove dead env vars
    • add import_start_date env var
  • Create sentinel-intel (stream connector)
    • use stream connector template
    • remove dead env vars

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
    • only connectors READMEs have been updated yet
  • Where necessary I refactored code to improve the overall quality

Further comments

@Powlinett Powlinett added the do not merge Do not merge this PR until this tag will be removed label Oct 2, 2024
@Powlinett Powlinett self-assigned this Oct 2, 2024
@Powlinett Powlinett force-pushed the issue/2298-microsoft-sentinel branch from 049b0d7 to 1bfb1e3 Compare October 3, 2024 15:43
@Powlinett Powlinett marked this pull request as ready for review October 4, 2024 08:44
@Powlinett Powlinett changed the title [Sentinel] Split former Sentinel connector into two new connecotrs (external import and stream) [Sentinel] Split former Sentinel connector into two new connectors (external import and stream) Oct 4, 2024
flavienSindou
flavienSindou reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@flavienSindou flavienSindou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review:

Great work ! I made some preliminary comments and remarks, I'll make a second pass.

stream/sentinel-intel/docker-compose.yml Outdated Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/api_handler.py Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/api_handler.py Outdated Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/api_handler.py Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_tests/fixtures/data_sample.json Outdated Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/utils.py Outdated Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/utils.py Outdated Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/utils.py Outdated Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/utils.py Outdated Show resolved Hide resolved
stream/sentinel-intel/src/sentinel_intel_connector/utils.py Outdated Show resolved Hide resolved
@Powlinett
Copy link
Member Author

@flavienSindou I think I resolved all your comments, could you double-check please? 🙏

flavienSindou
flavienSindou approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! 👍

stream/sentinel-intel/src/sentinel_intel_connector/utils.py Show resolved Hide resolved
@Powlinett Powlinett removed the do not merge Do not merge this PR until this tag will be removed label Oct 11, 2024
@Powlinett Powlinett merged commit 236eedd into master Oct 11, 2024
3 checks passed
@Powlinett Powlinett deleted the issue/2298-microsoft-sentinel branch October 11, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavienSindou flavienSindou flavienSindou approved these changes

@Megafredo Megafredo Awaiting requested review from Megafredo

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees

@Powlinett Powlinett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Powlinett @flavienSindou