Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crowdstrike] Fix error bytes-like object is required, and fix error logger #2653

Merged
merged 2 commits into from
Sep 15, 2024
Merged

[Crowdstrike] Fix error bytes-like object is required, and fix error logger #2653

merged 2 commits into from
Sep 15, 2024

Conversation

Megafredo
Copy link
Member

Proposed changes

  • Fix TypeError: a bytes-like object is required, not 'dict'
  • Fix Error Logger : TypeError: not all arguments converted during string formatting

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@Megafredo Megafredo added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Sep 13, 2024
@Megafredo Megafredo self-assigned this Sep 13, 2024
@Megafredo Megafredo linked an issue Sep 13, 2024 that may be closed by this pull request
[CrowdStrike] CrowdStrike connector internal error: a bytes-like object is required, not 'dict' #2647
Closed
@SamuelHassine SamuelHassine merged commit 86e0b30 into master Sep 15, 2024
3 checks passed
@SamuelHassine SamuelHassine deleted the bug/2647-crowdstrike branch September 15, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powlinett Powlinett Awaiting requested review from Powlinett

Assignees

@Megafredo Megafredo

Labels
bug use for describing something not working as expected filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CrowdStrike] CrowdStrike connector internal error: a bytes-like object is required, not 'dict'
2 participants
@Megafredo @SamuelHassine