Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZeroFox] add created_by_ref and opencti_observable_main_type to stix objects #2625

Merged
merged 3 commits into from
Sep 15, 2024
Merged

[ZeroFox] add created_by_ref and opencti_observable_main_type to stix objects #2625

merged 3 commits into from
Sep 15, 2024

Conversation

DNRRomero
Copy link
Contributor

@DNRRomero DNRRomero commented Sep 10, 2024 •
edited
Loading

Proposed changes

  • include the x_opencti_main_observable_type custom property on all observables
  • add author as custom property created_by_ref field on stix observables, normal one on other objects, based on a stix2 Identity object named ZeroFox

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@DNRRomero DNRRomero changed the title add created_by_ref and opencti_observable_main_type custom property t… add created_by_ref and opencti_observable_main_type to stix objects Sep 11, 2024
@DNRRomero DNRRomero changed the title add created_by_ref and opencti_observable_main_type to stix objects [ZeroFox] add created_by_ref and opencti_observable_main_type to stix objects Sep 12, 2024
@DNRRomero DNRRomero force-pushed the zerofox/modify_observables branch 2 times, most recently from 37f1e67 to 4e3e7ea Compare September 12, 2024 12:24
@Lhorus6
Copy link
Contributor

Lhorus6 commented Sep 14, 2024

@DNRRomero
Have you tested the connector with all the latest modifications you've made?
Does it launch and run smoothly?

If so, I'll merge this PR and test it on our side.

@SamuelHassine SamuelHassine merged commit 0f628eb into OpenCTI-Platform:master Sep 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lhorus6 Lhorus6 Awaiting requested review from Lhorus6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DNRRomero @Lhorus6 @SamuelHassine