[Cofense] NEW Cofense connector from Cofense #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helene-nguyen
added
the
do not merge
helene-nguyen
removed
the
do not merge
Megafredo
approved these changes
Aug 28, 2024
| - CONNECTOR_ID=ChangeMe | ||
| - CONNECTOR_TYPE=EXTERNAL_IMPORT | ||
| - CONNECTOR_NAME=CofenseIntel | ||
| - CONNECTOR_SCOPE= cofenseintel |
There was a problem hiding this comment.
An extra space after the egale
| #!/bin/sh | ||
|
|
||
| # Correct working directory | ||
| cd /opt/opencti-cofense |
There was a problem hiding this comment.
"connector" is missing this here "opencti-connector-cofense"
| log_level: 'info' | ||
|
|
||
| cofense: | ||
| user: 'ChangeMe' |
There was a problem hiding this comment.
Cofense-specific environment variables have excessive indentation
| new_interval = interval_sec - (timestamp - last_run) | ||
| helper.log_info( | ||
| "Connector will not run, next run in: " | ||
| + str(round(interval_sec / 60, 2)) |
There was a problem hiding this comment.
With interval_sec the displayed interval will always be 60 min (defined by default), I think the idea is to use new_interval instead to display the remaining time correctly.
str(round(interval_sec / 60, 2)) => str(round(new_interval / 60, 2))
| id=Incident.generate_id(mrti.label, created), | ||
| name=mrti.label, | ||
| description=f"{mrti.label}\n{mrti.executive_summary}", | ||
| object_marking_refs=[stix2.TLP_RED], # TODO: Is this correct? |
There was a problem hiding this comment.
Is it the original intention to define "TLP_RED" for all “intrusions set” and related “relationships” ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments