Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CrowdStrike] Fix KeyError for missing 'description' in report #2518

Merged
merged 1 commit into from
Aug 23, 2024
Merged

[CrowdStrike] Fix KeyError for missing 'description' in report #2518

merged 1 commit into from
Aug 23, 2024

Conversation

Megafredo
Copy link
Member

Proposed changes

  • Fix KeyError for missing 'description' in report
  • Update syntax for logger

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@Megafredo Megafredo added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Aug 23, 2024
@Megafredo Megafredo self-assigned this Aug 23, 2024
@Megafredo Megafredo linked an issue Aug 23, 2024 that may be closed by this pull request
[CrowdStrike] "KeyError" when importing a report #2517
Closed
@Megafredo Megafredo merged commit 3560f18 into master Aug 23, 2024
3 checks passed
@Megafredo Megafredo deleted the bug/2517-crowdstrike branch August 23, 2024 06:48
@helene-nguyen helene-nguyen linked an issue Sep 23, 2024 that may be closed by this pull request
[CrowdStrike] Fix KeyError in CrowdStrike processing #2697
Closed
@helene-nguyen helene-nguyen removed a link to an issue Sep 23, 2024
[CrowdStrike] Fix KeyError in CrowdStrike processing #2697
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

@Powlinett Powlinett Awaiting requested review from Powlinett

Assignees

@Megafredo Megafredo

Labels
bug use for describing something not working as expected filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CrowdStrike] "KeyError" when importing a report
2 participants
@Megafredo @helene-nguyen