Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mandiant] Handle multiple standard ID for a software when importing a report + fix state when entity use epoch time #2493

Merged
merged 4 commits into from
Aug 17, 2024
Merged

[Mandiant] Handle multiple standard ID for a software when importing a report + fix state when entity use epoch time #2493

merged 4 commits into from
Aug 17, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Aug 16, 2024 •
edited
Loading

Proposed changes

  • Generate new ID when importing Software from a Report when MANDIANT_VULNERABILITY_IMPORT_SOFTWARE_CPE is configured to False
  • Fix state when entity use epoch time: add a security for end_epoch => start_epoch + 2 days

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Aug 16, 2024
@helene-nguyen helene-nguyen self-assigned this Aug 16, 2024
@SamuelHassine SamuelHassine merged commit fe3c1c4 into master Aug 17, 2024
2 of 3 checks passed
@SamuelHassine SamuelHassine deleted the issue/2492-mandiant branch August 17, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelHassine SamuelHassine Awaiting requested review from SamuelHassine

@romain-filigran romain-filigran Awaiting requested review from romain-filigran

Assignees

@helene-nguyen helene-nguyen

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helene-nguyen @SamuelHassine