Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sekoia/Crowdstrike/Mandiant/AlienVault/RecordedFuture/CisaKEV] Modification on connector to use the new pycti connector helper scheduler #2459

Merged
merged 26 commits into from
Sep 10, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Aug 7, 2024

Why changes ?

As a new scheduler is added into client-python, these modifications on connectors is to use the new pycti connector helper scheduler

Here are the connectors concerned:

  • Cisa KEV
  • Recorded Future
  • Sekoia
  • Mandiant
  • Crowdstrike
  • AlienVault

Cisa KEV

Proposed changes

  • Modification on connector to use the new pycti connector helper scheduler (schedule_iso)
  • Catch exception outside running connector process by adding a traceback.print_exc()
  • Remove update_existing_data as it is deprecated
  • Improve the connector to fill in the "CISA KEV" field (x_opencti_cisa_kev)

Recorded Future

Proposed changes

  • Modification on connector to use the new pycti connector helper scheduler
  • Add new environment variable to enable or not Analyst Notes pulling
  • Refactored code

Mandiant

Proposed changes

  • Modification on connector to use the new pycti connector helper scheduler
  • Remove update_existing_data as it is deprecated

Sekoia

Proposed changes

  • Modification on connector to use the new pycti connector helper scheduler
  • Remove update_existing_data and confidence_level from config.yml.sample as it is deprecated

Crowdstrike

Proposed changes

  • Modification on connector to use the new pycti connector helper scheduler
  • Remove update_existing_data as it is deprecated

AlienVault

Proposed changes

  • Modification on connector to use the new pycti connector helper scheduler
  • Remove update_existing_data and confidence_level from config.yml.sample as it is deprecated

Related issues

Related PR

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Kedae
Kedae previously requested changes Aug 7, 2024
Copy link
Member

@Kedae Kedae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for release

@Kedae Kedae removed the do not merge Do not merge this PR until this tag will be removed label Aug 7, 2024
@helene-nguyen helene-nguyen force-pushed the opencti/issue/6325-all-for-release branch from b8f5218 to ee70cd6 Compare August 19, 2024 16:24
@Kedae Kedae dismissed their stale review August 23, 2024 12:19

Not needed

@helene-nguyen helene-nguyen added the do not merge Do not merge this PR until this tag will be removed label Aug 29, 2024
@helene-nguyen
Copy link
Member Author

Add label do not merge, waiting for release 6.3

Please check @labo-flg if more details is needed

helene-nguyen and others added 24 commits September 10, 2024 09:54
@Megafredo Megafredo force-pushed the opencti/issue/6325-all-for-release branch from b8e2a85 to a7ccd9b Compare September 10, 2024 08:34
@Megafredo Megafredo merged commit 78abfef into master Sep 10, 2024
3 checks passed
@Megafredo Megafredo added solved use to identify issue that has been solved (must be linked to the solving PR) and removed do not merge Do not merge this PR until this tag will be removed labels Sep 10, 2024
@Megafredo Megafredo deleted the opencti/issue/6325-all-for-release branch September 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment