Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HarfangLab] Fix bug create observable #2450

Merged
merged 2 commits into from
Aug 12, 2024
Merged

[HarfangLab] Fix bug create observable #2450

merged 2 commits into from
Aug 12, 2024

Conversation

Megafredo
Copy link
Member

Proposed changes

  • Implementation of a verification when creating an observable if its value is identical to that of the indicator, it is not created in HarfangLab.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@Megafredo Megafredo added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team labels Aug 5, 2024
@Megafredo Megafredo self-assigned this Aug 5, 2024
@Megafredo Megafredo linked an issue Aug 5, 2024 that may be closed by this pull request
[HarfangLab] Error : Failure observable created #2449
Closed
Powlinett
Powlinett approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me 👍

@Megafredo Megafredo merged commit f9b98ac into master Aug 12, 2024
3 checks passed
@Megafredo Megafredo deleted the bug/2449-harfanglab branch August 12, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powlinett Powlinett Powlinett approved these changes

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees

@Megafredo Megafredo

Labels
bug use for describing something not working as expected filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HarfangLab] Error : Failure observable created
2 participants
@Megafredo @Powlinett