Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VirusTotal] - Exception during IP address enrichment when VT does not return the expected information #2434

Merged
merged 3 commits into from
Aug 12, 2024
Merged

[VirusTotal] - Exception during IP address enrichment when VT does not return the expected information #2434

merged 3 commits into from
Aug 12, 2024

Conversation

romain-filigran
Copy link
Member

Proposed changes

Checks the presence of concerned fields

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@romain-filigran romain-filigran linked an issue Jul 31, 2024 that may be closed by this pull request
[VirusTotal] - Exception during IP address enrichment when VT does not return the expected information #2433
Closed
@romain-filigran romain-filigran self-assigned this Aug 1, 2024
@Megafredo Megafredo self-requested a review August 7, 2024 11:55
Megafredo
Megafredo approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@Megafredo Megafredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me !

@helene-nguyen helene-nguyen merged commit 2310e91 into master Aug 12, 2024
3 checks passed
@helene-nguyen helene-nguyen deleted the opencti/issue/2433 branch August 12, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo approved these changes

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

@SamuelHassine SamuelHassine Awaiting requested review from SamuelHassine

Assignees

@romain-filigran romain-filigran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VirusTotal] - Exception during IP address enrichment when VT does not return the expected information
3 participants
@romain-filigran @Megafredo @helene-nguyen