Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ready to be tested in the framework #2

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

ready to be tested in the framework #2

wants to merge 8 commits into from

Conversation

ssafaei
Copy link
Contributor

@ssafaei ssafaei commented Feb 11, 2018

No description provided.

Copy link
Member

@hsorby hsorby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have both expected_results and output directories?

@ssafaei
Copy link
Contributor Author

ssafaei commented Feb 11, 2018

When we run the example, OpenCMISS writes the results into the output folder, instead of spreading it in the main folder. The expected_results is for the testing framework to compare it with.

@hsorby
Copy link
Member

hsorby commented Feb 11, 2018

Yes, so we don't want the generated output in the repository.

Copy link
Member

@hsorby hsorby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation in the README.rst needs to be written for this example.

@hsorby
Copy link
Member

hsorby commented Feb 15, 2018

Does this example run with the develop branch from the prime Iron repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants