-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OpenCHAMI middleware to router.NewRouter() #29
Conversation
Seems that the OpenCHAMI |
Is the functionality in that upstream PR able to be put into the OpenCHAMI jwtauth for now? |
I think the OpenCHAMI jwtauth already has that functionality. I think we would just have to change the import in the OpenCHAMI middleware to point to the OpenCHAMI jwtauth for now and then rebase it with the upstream go-chi changes. Once it finally gets merged, we can change the import back to upstream and then delete the OpenCHAMI one. |
OK. Is this ready to be tested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like SMD is ready, but we'll have to switch the authenticator to use the OpenCHAMI jwtauth for now. |
I'm getting this error when building:
|
Looks like switching the import to use the OpenCHAMI jwtauth will solve this as discussed here. |
SMD is now building with those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested working. LGTM!
Addresses #27 by adding the OpenCHAMI middleware.