Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Allow setting certain arguments with environment variables #21

Open
davidallendj opened this issue May 1, 2024 · 1 comment
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@davidallendj
Copy link
Collaborator

Short Description
Some variables should be able to be set using environment variables. It might also make sense to use existing variables if they're set elsewhere (like SMD_HOST for example).

Definition of Done
This is done when environment variables can be passed to magellan

@davidallendj davidallendj added the enhancement New feature or request label May 1, 2024
davidallendj added a commit that referenced this issue May 7, 2024
Updated the `README.md` with Docker info
@davidallendj
Copy link
Collaborator Author

Update: This is partially implemented with the introduction of spf31/viper to handle configs. The environment variables are created by calling the viper.AutomaticEnv function. The documentation needs to be updated to include how the variables can be set.

@davidallendj davidallendj added the documentation Improvements or additions to documentation label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant