Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CoreDHCP (and Tftp) Container(s) to Quickstart #78

Merged
merged 19 commits into from
Nov 7, 2024
Merged

Add CoreDHCP (and Tftp) Container(s) to Quickstart #78

merged 19 commits into from
Nov 7, 2024

Conversation

synackd
Copy link
Contributor

@synackd synackd commented Oct 24, 2024

Add containers and configuration for CoreDHCP (built with the coresmd plugin) as well as a TFTP container to serve the relevant files. This is meant to replace dnsmasq, though it's files/config are kept around here for posterity.

Also, update the generate-configs.sh script to populate CoreDHCP configuration file, as well as update the README with relevant instructions.

@davidallendj
Copy link
Contributor

davidallendj commented Oct 28, 2024 •
edited
Loading

Quick note:
When running the current deployment-recipes, I get the following error related to dnsmasq:

Pulling dnsmasq (ghcr.io/openchami/dnsmasq:v0.1.10)...
v0.1.10: Pulling from openchami/dnsmasq
ERROR: no matching manifest for linux/arm64/v8 in the manifest list entries

So I'm wondering if merging this PR will also inadvertently add support for running the recipes on Linux ARM64 as well?

@davidallendj
Copy link
Contributor

Quick note: When running the current deployment-recipes, I get the following error related to dnsmasq:

Pulling dnsmasq (ghcr.io/openchami/dnsmasq:v0.1.10)...
v0.1.10: Pulling from openchami/dnsmasq
ERROR: no matching manifest for linux/arm64/v8 in the manifest list entries

So I'm wondering if merging this PR will also inadvertently add support for running the recipes on Linux ARM64 as well.

Just to answer my own question, I wasn't able to run the recipes on the raspberry PI due to the same error but with coresmd instead. I imagine when we get multi-arch support going, this will eventually be solved.

@synackd
Copy link
Contributor Author

synackd commented Oct 28, 2024

Yeah, it's only building amd64 containers in CI right now, so I can try to update that for multiarch. Should work after that.

@synackd
SMD: v2.16.0 -> v2.17.7
2fb6cdb 
This version of SMD includes the parsing code that adds BMC info from
Magellan that can be read by coresmd.
@alexlovelltroy alexlovelltroy mentioned this pull request Oct 30, 2024
Open
@synackd
Copy link
Contributor Author

synackd commented Oct 31, 2024

I've reduced the amount of things that the generate-configs script does and modified the quickstart README with the assumptions/defaults.

alexlovelltroy
alexlovelltroy approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@alexlovelltroy alexlovelltroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoreDHCP appears to be ready to go

@alexlovelltroy alexlovelltroy merged commit fac3242 into OpenCHAMI:main Nov 7, 2024
@rainest rainest mentioned this pull request Nov 7, 2024
Open
3 tasks
@synackd synackd deleted the coredhcp branch November 8, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidallendj davidallendj davidallendj left review comments

@alexlovelltroy alexlovelltroy alexlovelltroy approved these changes

@travisbcotton travisbcotton Awaiting requested review from travisbcotton

@njones-lanl njones-lanl Awaiting requested review from njones-lanl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@synackd @davidallendj @alexlovelltroy