Add tftp to coresmd #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlovelltroy
approved these changes
Nov 25, 2024
synackd
requested changes
Nov 25, 2024
Comment on lines
+101
to
+103
| // Start tftpserver | ||
| log.Info("starting TFTP server on port 69 with directory /tftpboot") | ||
| go startTFTPServer("/tftpboot") |
There was a problem hiding this comment.
Are we wanting to always use TFTP in coresmd or be able to toggle it on and off in the configuration file?
| # Download the latest ipxe binaries from https://github.com/OpenCHAMI/ipxe-binaries/releases and unpack them in the /tftpboot directory. | ||
| RUN set -ex \ | ||
| && mkdir -p /tftpboot \ | ||
| && latest_release_url=$(curl -s https://api.github.com/repos/OpenCHAMI/ipxe-binaries/releases/latest | jq -r '.assets[] | select(.name == "ipxe.tar.gz") | .browser_download_url') \ |
There was a problem hiding this comment.
I get:
#7 [3/4] RUN set -ex && mkdir -p /tftpboot && latest_release_url=$(curl -s https://api.github.com/repos/OpenCHAMI/ipxe-binaries/releases/latest | jq -r '.assets[] | select(.name == "ipxe.tar.gz") | .browser_download_url') &&
curl -L $latest_release_url -o /tmp/ipxe.tar.gz && tar -xzvf /tmp/ipxe.tar.gz -C /tftpboot && rm /tmp/ipxe.tar.gz
#7 0.097 + mkdir -p /tftpboot
#7 0.100 + curl -s https://api.github.com/repos/OpenCHAMI/ipxe-binaries/releases/latest
#7 0.100 + jq -r '.assets[] | select(.name == "ipxe.tar.gz") | .browser_download_url'
#7 0.100 /bin/sh: jq: not found
#7 0.383 + latest_release_url=
#7 ERROR: process "/bin/sh -c set -ex && mkdir -p /tftpboot && latest_release_url=$(curl -s https://api.github.com/repos/OpenCHAMI/ipxe-binaries/releases/latest | jq -r '.assets[] | select(.name == \"ipxe.tar.gz\") | .browser_do
wnload_url') && curl -L $latest_release_url -o /tmp/ipxe.tar.gz && tar -xzvf /tmp/ipxe.tar.gz -C /tftpboot && rm /tmp/ipxe.tar.gz" did not complete successfully: exit code: 127
------
> [3/4] RUN set -ex && mkdir -p /tftpboot && latest_release_url=$(curl -s https://api.github.com/repos/OpenCHAMI/ipxe-binaries/releases/latest | jq -r '.assets[] | select(.name == "ipxe.tar.gz") | .browser_download_url') &&
curl -L $latest_release_url -o /tmp/ipxe.tar.gz && tar -xzvf /tmp/ipxe.tar.gz -C /tftpboot && rm /tmp/ipxe.tar.gz:
0.097 + mkdir -p /tftpboot
0.100 + curl -s https://api.github.com/repos/OpenCHAMI/ipxe-binaries/releases/latest
0.100 + jq -r '.assets[] | select(.name == "ipxe.tar.gz") | .browser_download_url'
0.100 /bin/sh: jq: not found
0.383 + latest_release_url=
------
Dockerfile:12
jq needs to be added to the package list on Line 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tftp functionality to coresmd. Only serves out of
/tftpbootat the moment.