Support node autodetection via IP address #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function takes a node xname (among other args), which allows us to build other callers that can determine the xname in different ways (e.g. auto-detection via the initiating HTTP request's source IP). This also moves the responsibility for doing SMD MAC lookups away from the memstore's get-data function, and out into the "get user/meta/vendor data" function.
Due to Go HTTP handler weirdness, we return a function which itself handles the actual requests. This reduces code duplication substantially.
This still provides the MAC address that we need, and includes an IP address that we'll use shortly.
Data structures are hard.
|
The new SMD interface (particularly, decoding the new response from JSON to a slice of structs) is tested and functional on the teaching cluster. Should be fully ready for review now! |
davidallendj
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
LGTM. One thing to note is that it might make sense to change the non-secure /cloud-init[-secure] endpoint to specific routes to be clear what's being fetched in the future. For example, if I'm looking to fetch public keys, then it might make sense to have a separate /keys endpoint and leave the /cloud-init endpoint to be secure/non-secure based on the JWKS_URL environment variable being set. This is of course more so relevant to the other PR that was merged previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a class of endpoints (below) which do not require the querying node to specify its own MAC address for lookup purposes.
This should dramatically simplify the process of getting cloud-init data onto the node, since the server can now use the node's IP address (extracted from the HTTP request) to look up its xname from SMD.
This requires much less special effort on the node's part (i.e. logic that would need to be built into the boot image).
The new endpoints (i.e. those which perform IP-based SMD lookups) are:
/cloud-init[-secure]/user-data/cloud-init[-secure]/meta-data/cloud-init[-secure]/vendor-dataThe existing
/cloud-init[-secure]/<MAC address>/{user,meta,vendor}-dataendpoints continue to function normally.