Merge pull request #56 from Cray-HPE/CASMHMS-5821-part2

Add retry when getting a bootscript

.version

@@ -1 +1 @@
-1.25.1
+1.26.0

CHANGELOG.md

@@ -5,12 +5,22 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.26.0] - 2023-07-06
+
+### Added
+
+- Added retries to destructive bootscript CT tests for hms-nightly-integration runs.
+
 ## [1.25.1] - 2023-05-30
 
+### Changed
+
 - CASMCMS-8651: Update example fields in API spec to be links to S3 instead of dear departed ARS.
 
 ## [1.25.0] - 2023-05-22
 
+### Added
+
 - CASMHMS-6018: Add support for creating pre-signed URLs for `root=live:` parameters, enabling native dmsquash-live dracut usage.
 
 ## [1.24.0] - 2023-03-28

test/ct/api/3-destructive/test_bootscript.tavern.yaml

@@ -1,6 +1,6 @@
 # MIT License
 #
-# (C) Copyright [2022] Hewlett Packard Enterprise Development LP
+# (C) Copyright [2022-2023] Hewlett Packard Enterprise Development LP
 #
 # Permission is hereby granted, free of charge, to any person obtaining a
 # copy of this software and associated documentation files (the "Software"),
@@ -66,6 +66,14 @@ stages:
     status_code: 200
 
 - name: Query bootscript by xname
+  # Sometimes BSS returns a bootscript to re-attempt getting a bootscript, and this normally
+  # happens when BSS is syncing with HSM. Add retries to account for this.
+  # Example:
+  #  #!ipxe
+  #  sleep 10
+  #  chain https://api-gw-service-nmn.local/apis/bss/boot/v1/bootscript?mac=00:40:a6:42:3a:58&retry=1
+  max_retries: 15
+  delay_after: 2
   request:
     url: "{bss_base_url}/boot/v1/bootscript"
     method: GET
@@ -111,6 +119,14 @@ stages:
           expression: 'kernel --name .+bss_referral_token='
 
 - name: Query bootscript by MAC address
+  # Sometimes BSS returns a bootscript to re-attempt getting a bootscript, and this normally
+  # happens when BSS is syncing with HSM. Add retries to account for this.
+  # Example:
+  #  #!ipxe
+  #  sleep 10
+  #  chain https://api-gw-service-nmn.local/apis/bss/boot/v1/bootscript?mac=00:40:a6:42:3a:58&retry=1
+  max_retries: 15
+  delay_after: 2
   request:
     url: "{bss_base_url}/boot/v1/bootscript"
     method: GET
@@ -123,6 +139,14 @@ stages:
       content-type: text/plain; charset=UTF-8
 
 - name: Query bootscript by NID
+  # Sometimes BSS returns a bootscript to re-attempt getting a bootscript, and this normally
+  # happens when BSS is syncing with HSM. Add retries to account for this.
+  # Example:
+  #  #!ipxe
+  #  sleep 10
+  #  chain https://api-gw-service-nmn.local/apis/bss/boot/v1/bootscript?mac=00:40:a6:42:3a:58&retry=1
+  max_retries: 15
+  delay_after: 2
   request:
     url: "{bss_base_url}/boot/v1/bootscript"
     method: GET