Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently integrating COSMOS with CFS draco rc5 and as you can see here for better or worse they're using an 8-bit checksum.
I tried my best to follow the unit testing patterns that are already in the code base.
After double checking the code I realized it is a simple checksum, not a CRC. But hopefully this still is a valuable addition since it just exposes functionality that was already there.
Question: In your opinion, will adding a custom protocol that calculates the checksum be the best approach to add the checksum to COSMOS?
I'm also trying to learn the system, so any advice will be greatly appreciated.
Hope these changes make sense.
Lorenzo