BucketExplorer view files and breadcrumb paths #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
==========================================
+ Coverage 76.15% 76.31% +0.16%
==========================================
Files 602 603 +1
Lines 45733 46097 +364
Branches 822 844 +22
==========================================
+ Hits 34828 35180 +352
- Misses 10810 10821 +11
- Partials 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ryanmelt
requested changes
Nov 10, 2024
| @@ -127,9 +133,17 @@ | |||
| </template> | |||
| <template v-slot:item.action="{ item }"> | |||
| <v-icon | |||
| v-if="item.icon === 'mdi-file' && !isBinary(item.name)" | |||
There was a problem hiding this comment.
Would be better to have isText instead of isBinary. That way you know a file is viewable, rather than just excluding 4 extensions.
|
|
ryanmelt
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1264
closes #1679
closes #1680