Vue 3 / Vuetify 3 migration for COSMOS 6 #1539
Conversation
all cmdtlmserver playwright tests now pass, and the styling on that tool is fixed for the most part
all limits monitor tests now pass
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1539 +/- ##
==========================================
- Coverage 76.57% 76.27% -0.30%
==========================================
Files 620 603 -17
Lines 47107 46119 -988
Branches 850 837 -13
==========================================
- Hits 36071 35179 -892
+ Misses 10941 10844 -97
- Partials 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
closes #553 |
(this is largely still untested but gets me closer to where I need to be for now)
- Changed CommandParameterEditor to align with !1471. This whole component had to be tweaked a bunch, so I decided to knock that out too since it made this simpler. - Radio buttons in TopBar menus are currently not implemented. I think we'll need to revamp how we build those menus to support it in Vuetify 3.
Skipping one test for now until TlmViewer works
| @@ -112,8 +112,6 @@ def initialize(name, bit_offset, bit_size, data_type, endianness, array_size = n | |||
| @messages_disabled = nil | |||
| @state_colors = nil | |||
| @limits = PacketItemLimits.new | |||
| @persistence_setting = 1 | |||
| @persistence_count = 0 | |||
There was a problem hiding this comment.
I think these were left overs because they are also in PacketItemLimits
| limits['red_high'] = limits_values[3] | ||
| limits['green_low'] = limits_values[4] if limits_values[4] | ||
| limits['green_high'] = limits_values[5] if limits_values[5] | ||
| config['limits'][limits_set] = limits | ||
| end |
There was a problem hiding this comment.
This logic ensures there is always a limits key but it may just be empty unless self.limits.values or self.state_colors is defined
| config['limits'][limits_set] = limits | ||
| end | ||
| end | ||
| config['limits_response'] = self.limits.response.as_json(*a) if self.limits.response |
There was a problem hiding this comment.
This key shouldn't have been used ... it's already at config['limits']['response']
| require 'openc3-enterprise/utilities/metric' | ||
| rescue LoadError | ||
| # Open Source Edition - Do nothing here | ||
| end |
There was a problem hiding this comment.
Not sure if this was a future enhancement or what ... there is no openc3-enterprise/utilities/metric
There was a problem hiding this comment.
This exists and should be reverted.
| model = TriggerGroupModel.new(name: 'DEFAULT', scope: @scope) | ||
| model.create() | ||
| model.deploy() | ||
| end | ||
| end |
There was a problem hiding this comment.
Do these new ENTERPRISE conditionals require a migration?
| if ENTERPRISE | ||
| # Critical Cmd Microservice | ||
| deploy_critical_cmd_microservice(gem_path, variables, @parent) | ||
| end |
There was a problem hiding this comment.
Do these new ENTERPRISE conditionals require a migration?
There was a problem hiding this comment.
Yes removing the critical cmd microservice code requires a migration that only runs on open source.
|
|
||
| Topic.del("#{@scope}__openc3_autonomic") | ||
| Topic.del("#{@scope}__TRIGGER__GROUP") | ||
| end |
There was a problem hiding this comment.
Do these new ENTERPRISE conditionals require a migration?
| entries.concat(Dir.entries(folder).map { |entry| File.join(folder, entry) }) | ||
| end | ||
| entries = entries.sort() # run in alphabetical order | ||
| end |
There was a problem hiding this comment.
We now have both base and enterprise migrations ... we'll need to test this
| if File.exist?("../static/img/telemetry_viewer/widgets/#{keyword.downcase}.png") | ||
| page << "\n\n" | ||
| end | ||
| end |
There was a problem hiding this comment.
This is prep for the new images in the telemetry viewer screens
| entries.concat(Dir.entries(folder).map { |entry| File.join(folder, entry) }) | ||
| end | ||
| entries = entries.sort() # run in alphabetical order | ||
| end |
There was a problem hiding this comment.
If there is a folder argument doesn't seem to be handled.
| if ENTERPRISE | ||
| # Critical Cmd Microservice | ||
| deploy_critical_cmd_microservice(gem_path, variables, @parent) | ||
| end |
There was a problem hiding this comment.
Yes removing the critical cmd microservice code requires a migration that only runs on open source.
| @@ -168,7 +166,6 @@ def states=(states) | |||
| end | |||
|
|
|||
| @states = upcase_states | |||
| @state_colors ||= {} | |||
| require 'openc3-enterprise/utilities/metric' | ||
| rescue LoadError | ||
| # Open Source Edition - Do nothing here | ||
| end |
There was a problem hiding this comment.
This exists and should be reverted.
|
Draft PR with my changes so far
closes #75
closes #553