Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form for access values not intuitive #179

Closed
eginhard opened this issue Mar 27, 2024 · 8 comments
Closed

Form for access values not intuitive #179

eginhard opened this issue Mar 27, 2024 · 8 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@eginhard
Copy link

Somebody on the OSM World Discord server noticed that a lot of defibrillators in Switzerland are tagged with access=no (>90% of the worldwide cases: https://overpass-turbo.eu/s/1Jda). Most of them come from the Defikarte and one related import (https://www.openstreetmap.org/changeset/134128958). Many indeed seem to be located in companies/offices, but access=private would be a better fit there. Others are quite clearly meant for public access (https://www.openstreetmap.org/node/11536529969, https://www.openstreetmap.org/node/10781820605), or are even explicitly tagged that way in the description (https://www.openstreetmap.org/node/11371093369, https://www.openstreetmap.org/node/10203684217, https://www.openstreetmap.org/node/7786275859).

I guess this is because the Defikarte app and website form's switch for "Zugänglich/Accessible" defaults to False. There is no explanation at all for what this term means, so many people might just leave the default value. Providing an explicit choice between public and private access might be better here, defaulting to public (and otherwise tagging access=private instead of access=no).

@elektrolytmangel elektrolytmangel self-assigned this Mar 28, 2024
@elektrolytmangel elektrolytmangel added bug Something isn't working good first issue Good for newcomers labels Mar 28, 2024
@elektrolytmangel
Copy link
Collaborator

Thank you for opening the issue! I will discuss this with @chnuessli and create a fix for the issue.

@chnuessli
Copy link
Collaborator

Hi @eginhard. Thank you for reporting this isse.

For me there are two issues identified in this issue.

  1. The problem with the selection on the defi-form. Maybe there should be a dropdown with available options regarding wo the osm wiki.
  2. The problem with the imported data. I will check on that and find a solution that suits the community.

For me, access=no is and was always for defis that are not accessible fast and free. But permissive or private are more adequate sometimes.

@chnuessli
Copy link
Collaborator

For the defi-form we will improve the form selection to the following via dropdown:

Access

  • Yes
  • No
  • Private
  • Permissive

@eginhard What do you think?

Internal Link: https://chnuessli.atlassian.net/browse/DEFI-42

@eginhard
Copy link
Author

eginhard commented Apr 8, 2024

@chnuessli Yes, that sounds good.

@elektrolytmangel
Copy link
Collaborator

@eginhard We updated the web-ui. Can you please review and give a feedback if this is how it is expected. There is now also an info-button with more information about the different values to set for access.

@eginhard
Copy link
Author

Sorry for the late feedback @elektrolytmangel Yes, that looks good, thanks for updating it!

@elektrolytmangel
Copy link
Collaborator

Thanks! An update for the app with similar functionality is on the way. I will update the issue as soon it is live on iOS and Android.

@elektrolytmangel
Copy link
Collaborator

elektrolytmangel commented Jun 23, 2024

The feature is live on iOS and will be the next hours / days on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants