This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Revert mobile logging to file #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS does not permit filesystem access, need to find another way to support this case on iOS.
|
FYI, the PR build will pass as soon as the fix in #1465 is merged. |
drwasho
approved these changes
Feb 26, 2019
cpacia
approved these changes
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS does not permit filesystem access, need to find another way to support this case on iOS. I was unable to build this with
gomobileand assume I have some toolchain problems to resolve before I can again.Would appreciate it if someone could try building the frameworks before accepting this.