-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Software Marker Widget #1174
Conversation
160e4c5
to
13de3f7
Compare
c59252e
to
bc8e2c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add some padding on the right side of the buttons
- Consider making the buttons larger and splitting them into two rows
- Autoscale the height of the graph
I don't think autoscaling is the way to go here (for now), until users are allowed to stream in floats from another program. Then, it should be the only option for that source. |
Add python test script to send markers over the default port
Also, update Software Settings to account for this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It looks like there a few files where the whole file ended up as a diff for some reason. Can you double check your line endings and try restaging the files?
- I'm not sure how to provide external triggers via something like netcat. Can you provide some information (PR comment is fine) on this? Should the external process listen or host the connection? Does the stream have to be started first?
Maybe we should add it now that it's possible to stream in floats from an external source? |
Instead of this, users now have full control over the Y Axis, up to 20.0. Autoscale is kind of weird here since all values should be greater than 0, and it may cause "bouncing" when the graph resizes. Overall, the UX is likely better without the Y axis dynamically changing. EDIT: On second thought, users should have the freedom to send values > 20 and still see it, though it might look weird when the graph Y axis jumps from lets say 1000 to 1 after the data point leaves the graph. I'll add Auto as an option to Vert Scale, since we have a precedent in other widgets.
|
In the included Python example in The GUI will always listen on the specified port, and this does not use multicast. When the IP and Port are changed, the GUI will remake the UDP listener after leaving the textfield or pressing enter. A message will show at the bottom of the GUI and console log. This means the GUI and external process are completely independent and either can be started at any time. |
Closes #1091
Closes #1114
Account for the following:
Other consequential changes while reviewing keyboard shortcuts:
s
shortcut to Stop Streamingb
shortcut to Start Streamingd
shortcut as it was unused (it used to be for Cyton to reset board to defaults, this would not sync with ADS1299 settings UI)All of the above shortcuts are no longer useful or could cause issues if accidently pressed. We can still start/stop streaming using spacebar.