Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ganglion decompression #1173

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Update Ganglion decompression #1173

merged 7 commits into from
Aug 21, 2023

Conversation

philippitts
Copy link
Member

No description provided.

@philippitts philippitts requested a review from retiutut August 1, 2023 21:15
@philippitts philippitts self-assigned this Aug 1, 2023
@retiutut retiutut changed the base branch from master to development August 1, 2023 21:20
retiutut
retiutut reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@retiutut retiutut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we see some screenshot(s) of this working with the new firmware as a substitute for initial testing?

I can spin this up on previous firmware on my Ganglions.

@philippitts
Copy link
Member Author

philippitts commented Aug 1, 2023 •
edited
Loading

This is 5mV at 32Hz
image (1)

This is 5mV at 12Hz
image (2)

This is 1mV at 19Hz
image (3)

This is 3mV at 7Hz
image (4)

This is 4mV at 4Hz
image (5)

And this is 4mV at 4Hz on the old firmware (just as a sanity check)
image (6)

retiutut
retiutut reviewed Aug 1, 2023
View reviewed changes
.gitignore Show resolved Hide resolved
@philippitts philippitts changed the base branch from development to master August 8, 2023 18:48
@philippitts philippitts requested a review from retiutut August 8, 2023 18:48
retiutut
retiutut requested changes Aug 8, 2023
View reviewed changes
.gitignore Show resolved Hide resolved
@philippitts philippitts requested a review from retiutut August 8, 2023 19:51
@philippitts philippitts changed the base branch from master to development August 8, 2023 19:55
@philippitts philippitts force-pushed the update-ganglion-decompression branch 2 times, most recently from 6186574 to 5484779 Compare August 8, 2023 20:05
@philippitts philippitts changed the base branch from development to master August 8, 2023 21:45
@philippitts philippitts force-pushed the update-ganglion-decompression branch 13 times, most recently from edb764d to e6b4baf Compare August 9, 2023 00:35
@philippitts philippitts force-pushed the update-ganglion-decompression branch from e6b4baf to 0d90876 Compare August 9, 2023 00:36
@retiutut retiutut force-pushed the update-ganglion-decompression branch from 3f9c76b to 40302d1 Compare August 16, 2023 19:34
@philippitts philippitts force-pushed the update-ganglion-decompression branch from 40302d1 to 1d7b589 Compare August 16, 2023 21:41
retiutut
retiutut approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@retiutut retiutut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with v2 and v3.0.1 firmware! I'm no longer seeing an issue when using a signal generator, and this build of the GUI successfully works with both firmwares.

Great work Phil!

Also, Firmware Phil has a great ring to it. 🤔

.gitignore Show resolved Hide resolved
@retiutut retiutut merged commit 81de40d into master Aug 21, 2023
@retiutut retiutut deleted the update-ganglion-decompression branch August 21, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retiutut retiutut retiutut approved these changes

Assignees

@philippitts philippitts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippitts @retiutut