Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Processing 4.2 #1166

Merged
merged 14 commits into from
Aug 1, 2023
Merged

Update to Processing 4.2 #1166

merged 14 commits into from
Aug 1, 2023

Conversation

retiutut
Copy link
Member

@retiutut retiutut commented Jul 12, 2023

Modify App to be fully compatible with Processing 4

Closes #1111

There are still issues with child windows not being able to be resized and closed properly. To help us move forward for now, FilterUI, ConsoleLog, and EMG Settings UI have been made non-resizeable. A boolean has been left in FilterUI that would allow this again and easy testing, should a fix become available.


CI/CD Update

Closes #1170
Closes #1162
Closes #1171

@retiutut retiutut requested a review from philippitts July 12, 2023 21:16
@retiutut retiutut force-pushed the processing4-july-2023 branch 2 times, most recently from ff3934d to a3531b5 Compare July 20, 2023 21:39
@retiutut retiutut force-pushed the processing4-july-2023 branch 3 times, most recently from 6309a5b to cf06e64 Compare July 25, 2023 22:01
@retiutut retiutut force-pushed the processing4-july-2023 branch 6 times, most recently from 1deb098 to 3322de1 Compare July 28, 2023 23:06
Copy link
Member

@philippitts philippitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Recommend removing the debug lines that show up in the console log whenever the window is moved.
  • There is no window resizing cursor on Windows. Can this be added?

release_script/mac_only/Certificates_2023.p12.enc Outdated Show resolved Hide resolved
release_script/mac_only/dmgbuild_settings_old.py Outdated Show resolved Hide resolved
@retiutut
Copy link
Member Author

[ ] Recommend removing the debug lines that show up in the console log whenever the window is moved.

Steps to replicate?

@philippitts
Copy link
Member

[ ] Recommend removing the debug lines that show up in the console log whenever the window is moved.

Steps to replicate?

Launch from Processing 4 and then move the GUI window around. You should see something like this:

__MOVE__ 589 760
__MOVE__ 589 761
__MOVE__ 588 761
__MOVE__ 588 762
__MOVE__ 588 763
__MOVE__ 588 764
__MOVE__ 587 765
__MOVE__ 587 766
__MOVE__ 587 767
__MOVE__ 587 768
__MOVE__ 587 769
__MOVE__ 586 769

@retiutut
Copy link
Member Author

retiutut commented Jul 31, 2023

[ ] Recommend removing the debug lines that show up in the console log whenever the window is moved.

Steps to replicate?

Launch from Processing 4 and then move the GUI window around. You should see something like this:

__MOVE__ 589 760
__MOVE__ 589 761
__MOVE__ 588 761
__MOVE__ 588 762
__MOVE__ 588 763
__MOVE__ 588 764
__MOVE__ 587 765
__MOVE__ 587 766
__MOVE__ 587 767
__MOVE__ 587 768
__MOVE__ 587 769
__MOVE__ 586 769

This is something added by Processing 4. Only shows when running from the Processing 4 IDE.

There is no window resizing cursor on Windows. Can this be added?

We can resize windows from the top left. Unless we use JAVA2D renderer, but then the sketch crashes when resized. We are locked in for now to using P2D renderer.

@retiutut retiutut force-pushed the processing4-july-2023 branch from c0d85a4 to 55b5f88 Compare July 31, 2023 19:31
@retiutut retiutut force-pushed the processing4-july-2023 branch from 5c1e7f3 to 1b67b6b Compare August 1, 2023 21:10
@retiutut retiutut force-pushed the processing4-july-2023 branch from 1b67b6b to e4f18b5 Compare August 1, 2023 21:12
@philippitts philippitts self-requested a review August 1, 2023 21:16
@retiutut retiutut merged commit 1ea6ff2 into development Aug 1, 2023
@retiutut retiutut deleted the processing4-july-2023 branch August 21, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants