-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the creation and playback of OpenBCI GUI data files #1120
Conversation
Supports Cyton mode only in this PR
Still TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont get why synthetic board for brainflow is changed, it still has all these datatypes and maybe they can be useful for somebody
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix line endings in a few files.
…w_playback, and w_pulsesensor
Tested with:
|
In W_Playback the MenuList object does not perform well upon resizing. This should be replaced by an array of buttons or some other solution. All other calls to this UI object are not resized, as they are in the Control Panel. |
Sending to NYC office for final testing as performed here: #1120 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playback mode is working great on my end. I tested all the board configurations you mentioned. A few notes:
- The first time I click “Select OpenBCI playback file” after launching the GUI, the open file explorer window opens behind my other windows (Windows 10). Only happens the first time I click the button.
- Error when trying to record a 16 channel synthetic stream. Don’t get this problem when testing GUI 5.1.0
- Maybe add name of selected file below “Select OpenBCI playback file”. Not necessary but it confused me at first if I had selected a file
Ok @isaacplotkin, the fix for synthetic mode not launching is in. |
Great, synthetic mode fix is working for me. |
Fixes Refactor Playback Mode Classes #1119
Also changes Default Railed percentages to 90% and 75%.