Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the creation and playback of OpenBCI GUI data files #1120

Merged
merged 8 commits into from
May 15, 2023

Conversation

retiutut
Copy link
Member

@retiutut retiutut commented Feb 8, 2023

@retiutut
Copy link
Member Author

retiutut commented Feb 8, 2023

Still TODO:

  • Create datasourceplayback classes for every board
  • Add cases for every board to getDataSourcePlaybackClassFromFile() in DataSourcePlayback.pde
  • Create playback files using every board class
  • Test playback files from every board class

Copy link
Contributor

@Andrey1994 Andrey1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont get why synthetic board for brainflow is changed, it still has all these datatypes and maybe they can be useful for somebody

OpenBCI_GUI/BoardBrainFlowSynthetic.pde Show resolved Hide resolved
@philippitts philippitts removed their request for review May 1, 2023 23:25
OpenBCI_GUI/FileBoard.pde Outdated Show resolved Hide resolved
OpenBCI_GUI/W_Playback.pde Outdated Show resolved Hide resolved
Copy link
Member Author

@retiutut retiutut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix line endings in a few files.

@retiutut
Copy link
Member Author

retiutut commented May 5, 2023

Tested with:

  • Cyton
  • Cyton Daisy
  • Cyton Daisy + Accelerometer
  • Cyton Daisy + Analog Read
  • Cyton Daisy + Digital Read (with pressing PROG)
  • Ganglion Native Bluetooth
  • Ganglion BLE112 Dongle
  • Synthetic Board (yes this generates a file for testing and development reasons)
  • Playback History Widget playing back all of the above use cases in rapid succession within one session

@retiutut
Copy link
Member Author

retiutut commented May 5, 2023

In W_Playback the MenuList object does not perform well upon resizing. This should be replaced by an array of buttons or some other solution. All other calls to this UI object are not resized, as they are in the Control Panel.

@retiutut
Copy link
Member Author

retiutut commented May 5, 2023

Sending to NYC office for final testing as performed here: #1120 (comment)

Copy link

@isaacplotkin isaacplotkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playback mode is working great on my end. I tested all the board configurations you mentioned. A few notes:

  • The first time I click “Select OpenBCI playback file” after launching the GUI, the open file explorer window opens behind my other windows (Windows 10). Only happens the first time I click the button.
  • Error when trying to record a 16 channel synthetic stream. Don’t get this problem when testing GUI 5.1.0
    image
  • Maybe add name of selected file below “Select OpenBCI playback file”. Not necessary but it confused me at first if I had selected a file

@retiutut
Copy link
Member Author

retiutut commented May 9, 2023

Playback mode is working great on my end. I tested all the board configurations you mentioned. A few notes:

  • The first time I click “Select OpenBCI playback file” after launching the GUI, the open file explorer window opens behind my other windows (Windows 10). Only happens the first time I click the button.
  • Error when trying to record a 16 channel synthetic stream. Don’t get this problem when testing GUI 5.1.0
    image
  • Maybe add name of selected file below “Select OpenBCI playback file”. Not necessary but it confused me at first if I had selected a file

Great catch! I'll fix this here in this PR. The session settings for both playback and synthetic sessions were misnamed.

We do say in the status bar at the bottom of the GUI that the file was selected. Also appears in the console log. We do this in the status bar since there is enough space to display longer file names.

Screen Shot 2023-05-09 at 4 42 35 PM

@retiutut
Copy link
Member Author

retiutut commented May 9, 2023

Ok @isaacplotkin, the fix for synthetic mode not launching is in.

@isaacplotkin
Copy link

Great, synthetic mode fix is working for me.

@retiutut retiutut requested a review from isaacplotkin May 15, 2023 17:38
@retiutut retiutut merged commit eae1ab2 into development May 15, 2023
@retiutut retiutut deleted the refactor-playback-classes branch May 15, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants