Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI-wide Settings class #997

Closed
retiutut opened this issue Sep 13, 2021 · 3 comments
Closed

GUI-wide Settings class #997

retiutut opened this issue Sep 13, 2021 · 3 comments
Assignees
Milestone

Comments

@retiutut
Copy link
Member

retiutut commented Sep 13, 2021

Is your feature request related to a problem? Please describe.
Not related to a problem per-say.

Describe the solution you'd like
A handful of features should persist once the GUI has been run for the first time and then in each subsequent app instance.

*Example: Expert Mode.

Making this class and doing the two above settings would be a great start.

Data can be stored along with other settings in USER/Documents/OpenBCI_GUI/Settings

Describe alternatives you've considered
Session settings should pertain only to the session.

Additional context
Need to make this class follow the pattern set forth in the the hardware settings class. DO NOT use the pattern set forth in the Session Settings class, since this needs to be refactored.

@retiutut retiutut added this to the 5.0.7 milestone Sep 13, 2021
@retiutut retiutut self-assigned this Sep 13, 2021
@retiutut
Copy link
Member Author

retiutut commented Sep 16, 2021

Relates to #970 in that there may be some residual settings that need to be in this new GUI-wide class.

@retiutut
Copy link
Member Author

Cyton Data smoothing is a session-specific setting and should remain in sessionSettings.pde class.

@retiutut
Copy link
Member Author

Testing is passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant