Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Tests: Fix Some Bad Integration Test Params #6964

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[BugFix] Tests: Fix Some Bad Integration Test Params #6964

merged 1 commit into from
Nov 26, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • A couple of improbable combinations for Benzinga.
    • Out-of-range limit param for yFinance

  2. What?:

    • Fixes 5 tests, failures explainable by bad params.

  3. Impact:

    • Fixes apply to:
      • equity/integration/test_equity_api.py
      • equity/integration/test_equity_python.py
      • news/integration/test_news_api.py
      • news/integration/test_news_python.py

  4. Testing Done:

    • All other unit and integration tests pass locally.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Nov 26, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit cf36a2f Nov 26, 2024
13 checks passed
@IgorWounds IgorWounds deleted the bugfix/fix-test-params branch December 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds