Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Limit Param For yFinance Financials #6962

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

  2. What?:

    • Applies to balance, cash, and income.
    • Add le=5 to the yFinance model definition.
    • Filter out the response if limit < 5.
  3. Impact:

    • For provider='yfinance', a validation error will raise when the limit is more than 5.
  4. Testing Done:

Screenshot 2024-11-24 at 6 29 56 PM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Nov 25, 2024
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default limit - 5
Is it enough as a default one?

@deeleeramone
Copy link
Contributor Author

Default limit - 5 Is it enough as a default one?

That's the maximum number of results returned from yFinance.

@deeleeramone deeleeramone added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 1267573 Nov 25, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/yfinance-financials-limit branch December 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] limit parameter not working
2 participants