Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Handle ValidationError Better #6955

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Nov 21, 2024

  1. Why?:

    • Some ValidationErrors were raising as Unexpected in the Python Interface.
  2. What?:

    • Remove the secondary condition in the instance check for ValidationError

    • Remove redundant str wrapper inside f-string.

  3. Impact:

    • More consistent ValidationError,
  4. Testing Done:

Making a validation error by changing the content of a string field to a list without changing the model.

Before:

Screenshot 2024-11-20 at 11 24 17 PM

After:

Query:

Screenshot 2024-11-21 at 12 11 21 AM

Data:

Screenshot 2024-11-21 at 12 14 30 AM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Nov 21, 2024
@deeleeramone deeleeramone added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 7d8202f Nov 25, 2024
10 checks passed
@deeleeramone deeleeramone deleted the bugfix/exceptions branch November 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants