Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Bump openbb-core Dependencies In pyproject.toml #6794

Merged
merged 12 commits into from
Oct 22, 2024
Merged

[BugFix] Bump openbb-core Dependencies In pyproject.toml #6794

merged 12 commits into from
Oct 22, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Oct 17, 2024 •
edited
Loading

  1. Why?:

  2. What?:

    • Version bumps for:

      • uvicorn
      • websockets
      • fastapi
      • importlib-metadata
      • ruff

    • openbb-devtools needs to update for the linting actions.

  3. Impact:

  4. Testing Done:

    • The new lock file was compiled with Python 3.9, and did not encounter any conflicts or errors associated with version changes.

The complete resolution of the issue will come about from the next minor release.

@deeleeramone deeleeramone added platform OpenBB Platform P3 labels Oct 17, 2024
@github-actions github-actions bot added bug Fix bug v4 PRs for v4 labels Oct 17, 2024
@IgorWounds IgorWounds requested a review from piiq October 17, 2024 14:45
@IgorWounds
Copy link
Contributor

Tagging @piiq

piiq
piiq reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added 2 inline comments

openbb_platform/core/pyproject.toml Show resolved Hide resolved
openbb_platform/core/pyproject.toml Outdated Show resolved Hide resolved
@piiq piiq added the security label Oct 19, 2024
@deeleeramone deeleeramone added the do not merge Label to prevent pull request merge label Oct 19, 2024
@deeleeramone
Copy link
Contributor Author

@piiq Removing the Starlette pin prevents the issue from being resolved in this PR. poetry.lock is what Dependabot reads.

Screenshot 2024-10-19 at 9 14 32 AM

@deeleeramone deeleeramone removed the do not merge Label to prevent pull request merge label Oct 21, 2024
@deeleeramone deeleeramone added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit da0ba41 Oct 22, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/bump-core-dependencies branch October 23, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiq piiq piiq approved these changes

@IgorWounds IgorWounds IgorWounds approved these changes

@hjoaquim hjoaquim Awaiting requested review from hjoaquim

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

Assignees

@deeleeramone deeleeramone

Labels
bug Fix bug P3 platform OpenBB Platform security v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deeleeramone @IgorWounds @piiq