Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[task] created a cryptocurrency trend analysis notebook | closes #6709 #6728

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

theghostmac
Copy link
Contributor

This notebook provides an analysis of Ethereum (ETH) price trends and volatility by leveraging OpenBB's historical data to calculate and visualize moving averages, examine trading volume pattern, and assess price volatility.

Key findings from the analysis include:

  • Price Trend
  • Moving Averages
  • Trading Volume
  • Volatility

These insights are valuable for traders and investors seeking to understand Ethereum's market dynamics and make informed decisions.

Feel free to increase the timeframe to see further results.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

{
"cell_type": "code",
"source": [
"!pip install openbb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run !pip install openbb -q -- that will suppress the installs and make it look nicer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the first cell to use this instead.

Comment on lines 361 to 365
"def calculate_ma(data, window):\n",
" \"\"\"\n",
" This function calculates the Simple Moving Average (SMA) of a time series data for a specified window size.\n",
" \"\"\"\n",
" return [sum(data[max(i-window+1, 0):i+1])/min(i+1, window) for i in range(len(data))]\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a slight issue that will raise a bug if window>len(data).

This notebook in general could be simplified moving to pandas and using the .to_df() method. This way you can just use rolling

"plt.tight_layout()\n",
"plt.show()\n",
"\n",
"print(\"Analyzing Ethereum trading volume...\")\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What analysis is there other than a chart?

Copy link
Contributor Author

@theghostmac theghostmac Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added more Quantitative Analysis metrics to the notebook like RSI and trading signals, etc.

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 2, 2024

Hey! Thanks for taking the time to contribute as part of hacktoberfest!

I have left a couple comments throughout the notebook.

@theghostmac
Copy link
Contributor Author

Thanks for going through the Notebook. I will be making the changes now.

I was streaming on YT, teaching my community how to contribute to open source during Hacktoberfest, and they suggested OpenBB.

@deeleeramone
Copy link
Contributor

I would like to request that the spaces be removed from the file name, SnakeCase. Also, we can shorten it by removing "Crypto", because I think everyone knows that Ethereum is in this asset class.

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 16, 2024

/award 300

Copy link

oss-gg bot commented Oct 16, 2024

Awarding theghostmac: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/theghostmac

@jmaslek jmaslek added this pull request to the merge queue Oct 18, 2024
Merged via the queue into OpenBB-finance:develop with commit 286e261 Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants