-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[task] created a cryptocurrency trend analysis notebook | closes #6709 #6728
Conversation
{ | ||
"cell_type": "code", | ||
"source": [ | ||
"!pip install openbb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run !pip install openbb -q
-- that will suppress the installs and make it look nicer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the first cell to use this instead.
"def calculate_ma(data, window):\n", | ||
" \"\"\"\n", | ||
" This function calculates the Simple Moving Average (SMA) of a time series data for a specified window size.\n", | ||
" \"\"\"\n", | ||
" return [sum(data[max(i-window+1, 0):i+1])/min(i+1, window) for i in range(len(data))]\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a slight issue that will raise a bug if window>len(data).
This notebook in general could be simplified moving to pandas and using the .to_df() method. This way you can just use rolling
"plt.tight_layout()\n", | ||
"plt.show()\n", | ||
"\n", | ||
"print(\"Analyzing Ethereum trading volume...\")\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What analysis is there other than a chart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added more Quantitative Analysis metrics to the notebook like RSI and trading signals, etc.
Hey! Thanks for taking the time to contribute as part of hacktoberfest! I have left a couple comments throughout the notebook. |
Thanks for going through the Notebook. I will be making the changes now. I was streaming on YT, teaching my community how to contribute to open source during Hacktoberfest, and they suggested OpenBB. |
I would like to request that the spaces be removed from the file name, SnakeCase. Also, we can shorten it by removing "Crypto", because I think everyone knows that Ethereum is in this asset class. |
/award 300 |
Awarding theghostmac: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/theghostmac |
This notebook provides an analysis of Ethereum (ETH) price trends and volatility by leveraging OpenBB's historical data to calculate and visualize moving averages, examine trading volume pattern, and assess price volatility.
Key findings from the analysis include:
These insights are valuable for traders and investors seeking to understand Ethereum's market dynamics and make informed decisions.
Feel free to increase the timeframe to see further results.