Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file : Created Notebook for Portfolio Optimization Using Modern Portfolio Theory (Hacktoberfest) #6726

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

ambroseikpele
Copy link
Contributor

@ambroseikpele ambroseikpele commented Oct 1, 2024

Linked: #6708

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 1, 2024

Hey! Welcome to the OpenBB Contributor club and thanks for taking the time to contribute.

I am going to just give some of my thoughts on this.

I was hoping to see a bit more of the "what is going on with mpt/mvo". You have a brief sentence, but I don't see the problem framed at all, i.e a section on what we are doing with MVO -- and it is impossible not to describe without a few formulas.

Great usage of openbb, and the list allows people to define anything they want to look at.

When you go into setting up the problem, I was expecting to see some explanation of the covraiance, especially when you use a shrinkage method. Lets be more explicit about what the notebook does and why.

Same with the actual calculations. PYPFOPT is a great library (shoutout rob), but there is no explanation of what the efficient frontier is or what and why you use CLA.

Also in the intro you say maximize returns while minimizing risk (ie I was thinking you would go sharpe,=), but then you take min volatility, so slight discontinuity.

Very nice visualization.

In general, I was just hoping for some more explanation of what was going on here. Thoughts?

…rn Portfolio Theory (Hacktoberfest)

Addressed review comments
@ambroseikpele
Copy link
Contributor Author

Thank you for feedback @jmaslek

I have updated the Notebook taking your feedback into account

@ambroseikpele
Copy link
Contributor Author

Also, about editing the oss.gg folder, which of the files in the code_side_quests folder should I add my details. The closest seems to be 1-openbb-integration.md ; Side Quest: Integrate OpenBB into a dashboard or web application, but i am confused because the issue requested for a Notebook and not a dashboard neither a web app.

thanks

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 2, 2024

Also, about editing the oss.gg folder, which of the files in the code_side_quests folder should I add my details. The closest seems to be 1-openbb-integration.md ; Side Quest: Integrate OpenBB into a dashboard or web application, but i am confused because the issue requested for a Notebook and not a dashboard neither a web app.

thanks

Yeah that was my mistake - I dont think that was needed for this.

@jmaslek
Copy link
Collaborator

jmaslek commented Oct 14, 2024

/award 300

Copy link

oss-gg bot commented Oct 14, 2024

Awarding ambroseikpele: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/ambroseikpele

@ambroseikpele
Copy link
Contributor Author

/award 300

Thank you

Copy link

oss-gg bot commented Oct 15, 2024

You are not allowed to award points! Please contact an admin.

@piiq piiq added this pull request to the merge queue Oct 18, 2024
Merged via the queue into OpenBB-finance:develop with commit edc32d1 Oct 18, 2024
6 checks passed
Copy link

oss-gg bot commented Oct 18, 2024

Awarding ambroseikpele: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/ambroseikpele

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants